[MAINTENANCE] Simplify and unify check for doc existence #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatrycze-volk
force-pushed
the
add-doc
branch
from
2b5a658 to
8b68fa8
Compare
It also fixes in some places missing parts of check in ifs
beatrycze-volk
force-pushed
the
add-doc
branch
from
8b68fa8 to
bbeff41
Compare
sebastian-meyer
added
☇ bug
sebastian-meyer
approved these changes
Feb 5, 2023
sebastian-meyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check happens quiet often and in incoming PR (#878) will be added again so it is beneficial to make it in one place.
It also fixes in some places missing parts of check in ifs:
Possible NULL on
$this->document->getDoc()